Use dev branches for immucore and kairos-agent #1497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmykarily
force-pushed
the
1448-use-yip
branch
4 times, most recently
from
7e5eaf8 to
6139299
Compare
jimmykarily
force-pushed
the
1448-use-yip
branch
2 times, most recently
from
4e20bff to
57d7f98
Compare
jimmykarily
commented
Jun 30, 2023
Comment on lines
+309
to
320
| ARG KAIROS_AGENT_DEV=true | ||
| ARG KAIROS_AGENT_DEV_BRANCH=1448-use-yip | ||
| IF [ "$KAIROS_AGENT_DEV" = "true" ] | ||
| RUN rm -rf /usr/bin/kairos-agent | ||
| COPY github.com/kairos-io/kairos-agent:$KAIROS_AGENT_DEV_BRANCH+build-kairos-agent/kairos-agent /usr/bin/kairos-agent | ||
| END | ||
| # END | ||
|
|
||
| # TEST IMMUCORE FROM BRANCH | ||
| ARG IMMUCORE_DEV | ||
| ARG IMMUCORE_DEV_BRANCH=master | ||
| ARG IMMUCORE_DEV=true | ||
| ARG IMMUCORE_DEV_BRANCH=1448-use-yip | ||
| IF [ "$IMMUCORE_DEV" = "true" ] |
There was a problem hiding this comment.
This PR is not meant to be merged as is. It's pointing to dev branches of kairos-agent and immucore which consume this yip version: mudler/yip#96
The merging process should be:
- merge the yip PR
- bump kairos-agent and immucore to use that yip version
- tag new releases of kairos-agent and immucore
- consume those versions in kairos
The rest of the changes in this PR can be then merged or moved to another PR.
so that we run tests with the yip implementation of the layout plugin Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
force-pushed
the
1448-use-yip
branch
from
b87e534 to
bcd33ee
Compare
|
this is a test PR, closing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that we run tests with the yip implementation of the layout plugin
This is a possible proper fix for #1448
as opposed to the quick fix here: https://github.com/kairos-io/immucore/compare/1448-resizefs